[Openmp-commits] [PATCH] D133053: [Libomptarget] Change device free routines to accept the allocation kind

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a subscriber: RaviNarayanaswamy.
JonChesterfield added a comment.

I think changing the API of `__tgt_rtl_data_delete` is good. I like the map lookup disappearing from the cuda plugin. It'll mean mixing plugins and libomptargets from different toolchains will tend to segfault. They're not certain to be semantically interchangeable even if we keep the function name and type the same though.

@jdoerfert / @ronlieb / @RaviNarayanaswamy any of you aware of a requirement that forces slower/clumsy/backwards-compatible here, aka renaming the entry point to __tgt_rtl_data_delete_v2 or similar?

In particular changing the llvm_ prefixed function is definitely OK, anyone using llvm_ prefixed openmp functions signed up for semantics changing en route to standardisation.

Patch itself looks good to me, thanks for writing it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133053/new/

https://reviews.llvm.org/D133053