[Openmp-commits] [PATCH] D132005: Add non-blocking support for target nowait regions

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:700
+postProcessingTargetDataEnd(DeviceTy *Device,
+                            SmallVector<PostProcessingInfo> PostProcessingPtrs,
+                            void * FromMapperBase) {
----------------
nit: a vector of `PostProcessingInfo` called `PostProcessingPtrs` is confusing.


================
Comment at: openmp/runtime/src/kmp_tasking.cpp:1099
+    // Note: no need to translate gtid to its shadow. If the current thread is a
+    // hidden helper one, than the gtid is already correct. Otherwise, hidden
+    // helper threads are disabled, and gtid refers to a OpenMP thread. 
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132005/new/

https://reviews.llvm.org/D132005