[Openmp-commits] [PATCH] D132579: [libomptarget][amdgpu] enable tests whenever possible.

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added a comment.

In D132579#3746555 <https://reviews.llvm.org/D132579#3746555>, @JonChesterfield wrote:

> This replaces "enable tests when there's a GPU" with "enable tests when HSA is on the system". That would make it match nvptx. Did you consider the other way round, only run nvptx tests when a GPU is present, as opposed to when CUDA is installed?

Yes. The logic is changed to enable tests when HSA is on the system. Enable tests is not equal to run tests.
My use case is, I build llvm on a node with many CPU cores. Then grab an AMD GPU node to run amdgpu tests and a NVDIA PGU node to run nvptx tests. All the nodes share a file system.

The old cmake has another broken logic. It will build amdgpu-arch since it is a CMake target but it tries to run amdgpu-arch via execute_process at CMake stage before it gets built. I'm pretty sure something in the environment gets pulled in instead of the one to be built.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132579/new/

https://reviews.llvm.org/D132579