[Openmp-commits] [openmp] acfe0d3 - [openmp] Remove __ANDROID_API__ < 19 workaround

Fangrui Song via Openmp-commits openmp-commits at lists.llvm.org
Fri Aug 12 22:15:42 PDT 2022


Author: Fangrui Song
Date: 2022-08-12T22:15:38-07:00
New Revision: acfe0d3b157361433977c3341a0ec88ebeabc2f7

URL: https://github.com/llvm/llvm-project/commit/acfe0d3b157361433977c3341a0ec88ebeabc2f7
DIFF: https://github.com/llvm/llvm-project/commit/acfe0d3b157361433977c3341a0ec88ebeabc2f7.diff

LOG: [openmp] Remove __ANDROID_API__ < 19 workaround

https://github.com/android/ndk/wiki/Changelog-r24 shows that the NDK has
moved forward to at least a minimum target API of 19. Remove old workaround.

Added: 
    

Modified: 
    openmp/runtime/src/z_Linux_util.cpp

Removed: 
    


################################################################################
diff  --git a/openmp/runtime/src/z_Linux_util.cpp b/openmp/runtime/src/z_Linux_util.cpp
index 91edf0254a772..0e9c8e79cbd79 100644
--- a/openmp/runtime/src/z_Linux_util.cpp
+++ b/openmp/runtime/src/z_Linux_util.cpp
@@ -765,13 +765,6 @@ void __kmp_create_worker(int gtid, kmp_info_t *th, size_t stack_size) {
      and also gives the user the stack space they requested for all threads */
   stack_size += gtid * __kmp_stkoffset * 2;
 
-#if defined(__ANDROID__) && __ANDROID_API__ < 19
-  // Round the stack size to a multiple of the page size. Older versions of
-  // Android (until KitKat) would fail pthread_attr_setstacksize with EINVAL
-  // if the stack size was not a multiple of the page size.
-  stack_size = (stack_size + PAGE_SIZE - 1) & ~(PAGE_SIZE - 1);
-#endif
-
   KA_TRACE(10, ("__kmp_create_worker: T#%d, default stacksize = %lu bytes, "
                 "__kmp_stksize = %lu bytes, final stacksize = %lu bytes\n",
                 gtid, KMP_DEFAULT_STKSIZE, __kmp_stksize, stack_size));


        


More information about the Openmp-commits mailing list