[Openmp-commits] [PATCH] D129694: [OPENMP] Make declare target static global externally visible

Fri Aug 12 05:20:05 PDT 2022

jhuber6 added a comment.

In D129694#3718225 <https://reviews.llvm.org/D129694#3718225>, @ssquare08 wrote:

> Yes, that is correct. My question is, is it okay to mangle the host and the device side independently using `getTargetEntryUniqueInfo`? The reason I am asking is because you had expressed some concerns regarding mangling them separately. Or, maybe there is a way to mangle the original name before the host and device compilation split?

You'll need to mangle them separately for the device and host, the difference is that we want to use a function that shares the input to create the mangled name. As far as I know, this is done using a metadata node in the host bitcode. So as long as we share the same method that kernels use it should be fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129694/new/

https://reviews.llvm.org/D129694