[Openmp-commits] [PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

[Jennifer Yu via Phabricator via Openmp-commits]

jyu2 added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9073
     SmallVector<MapData, 4> DeclComponentLists;
+    if (DevPointersMap.count(VD)) {
+      // For member fields list in is_device_ptr, store it in
----------------
ABataev wrote:
> If VD is nullptr, why do we need this check?
Yes.  You are right.  It is unnecessary change.  I removed.  Thanks.  Jennifer 


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9080
+          DeclComponentLists.emplace_back(MCL, OMPC_MAP_to,
+                                          OMPC_MAP_MODIFIER_unknown, true,
+                                          nullptr, nullptr);
----------------
ABataev wrote:
> comment with the name of parameter, associated with `true` value.
Sorry.  Added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129608/new/

https://reviews.llvm.org/D129608