[Openmp-commits] [PATCH] D129694: [OPENMP] Make declare target static global externally visible

Mon Aug 8 15:05:53 PDT 2022

ssquare08 added a comment.

In D129694#3685207 <https://reviews.llvm.org/D129694#3685207>, @jhuber6 wrote:

> I still think we shouldn't bother making all the noise containing the original name. Just mangle it and treat it like every other declare target variable without introducing any extra complexity. These symbols never should've been emitted in the first place so I'm not concerned if someone cracks open a binary and sees some ugly names. CUDA and HIP just mangle the declaration directly as far as I'm aware.

If that's the preference I can make changes as suggested. You mentioned CUDA and HIP mangle the declaration directly. To me it looks like they mangle it on host and device separately. Is that not correct? If so, can you point me to the source you are referring to?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129694/new/

https://reviews.llvm.org/D129694