[Openmp-commits] [PATCH] D129875: [Libomptarget] Make libomptarget an LLVM library

[Kazushi Marukawa via Phabricator via Openmp-commits]

kaz7 added a comment.

In D129875#3704796 <https://reviews.llvm.org/D129875#3704796>, @JonChesterfield wrote:

> Libomptarget is host code. There's another library called DeviceRTL which runs on the accelerator and that won't be linking in llvm libs or zlib.

Thank you for the correction!  Then, I'm not sure why cmake for libomptarget fails to find terminfo and zlib although those are used by llvm itself.

> We could audit which llvm libs are transitively depended on and see whether they use zlib or terminfo and try to avoid them if necessary, but that's really better solved at the llvm libs level. Only declare the dependency on libs that use them. I'd guess that hasn't been worth doing so far so using any llvm lib is taken as a sign that you may as well link those two as well, unless you opted out using the top level defines. Doesn't look especially worth the cmake complexity and maintenance cost to me.

That's true.  It's much easier and I agree with you.  Ok.  Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129875/new/

https://reviews.llvm.org/D129875