[Openmp-commits] [PATCH] D129875: [Libomptarget] Make libomptarget an LLVM library

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

In D129875#3704714 <https://reviews.llvm.org/D129875#3704714>, @kaz7 wrote:

> In D129875#3704145 <https://reviews.llvm.org/D129875#3704145>, @jhuber6 wrote:
>
>> Libomptarget now depends on the LLVM libraries , so whatever dependencies LLVM has libomptarget needs to have as well. Is it possible for you to build with `-DLLVM_ENABLE_TERMINFO=OFF -DLLVM_ENABLE_ZLIB=OFF`? I'd assume that would stop LLVM from looking for it and prevent `libomptarget` from picking it up either.
>
> Yes.  Adding those options to not only libomptarget but also whole llvm solves this problem.  Thank you.
>
> But, do you really want to make libomptarget depends on LLVM libraries including terminfo and zlib although libomptarget is running on accelarators?  Isn't it possible to separate LLVM libraries for hosts and for targets somehow?  Just a thought.

LLVM builds and links static libraries by default, so unless changed by the user the LLVM libraries shouldn't be required by user applications using `libomptarget`. Is the problem here that `LLVM` is pulling in dependencies for `libz` and `terminfo` that aren't statically removed in the default build configuration? If that's the case it would be a good idea to try to remove those unless we explicitly need them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129875/new/

https://reviews.llvm.org/D129875