[Openmp-commits] [PATCH] D129875: [Libomptarget] Make libomptarget an LLVM library

Sat Aug 6 05:24:49 PDT 2022

jhuber6 added a comment.

In D129875#3704144 <https://reviews.llvm.org/D129875#3704144>, @kaz7 wrote:

> Hi, I am having configuration error after this patch like it cannot find zlib and terminfo to compile libomptarget.  Why those are required for libomptarget is that those libraries are listed in `install/lib/cmake/llvm/LLVMConfig.cmake` like below if I compile llvm with default setting.  it's clear that libomptarget doesn't require them, but this patch change it to require similar libraries as llvm itself.  I would like to disable them for only libomptarget compiling.  Do you know how to do that?  Please let me know any way to solve this situation.  Thank you!
>
>   set(LLVM_ENABLE_TERMINFO TRUE)
>   if(LLVM_ENABLE_TERMINFO)
>     find_package(Terminfo)
>   endif()
>   
>   set(LLVM_ENABLE_ZLIB 1)
>   if(LLVM_ENABLE_ZLIB)
>     set(ZLIB_ROOT )
>     find_package(ZLIB)
>   endif()

Libomptarget now depends on the LLVM libraries , so whatever dependencies LLVM has libomptarget needs to have as well. Is it possible for you to build with `-DLLVM_ENABLE_TERMINFO=OFF -DLLVM_ENABLE_ZLIB=OFF`? I'd assume that would stop LLVM from looking for it and prevent `libomptarget` from picking it up either.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129875/new/

https://reviews.llvm.org/D129875