[Openmp-commits] [PATCH] D131089: [Libomptarget] Explicitly init / deinit libomptarget from the user

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:271
 static bool isOffloadDisabled() {
-  if (PM->TargetOffloadPolicy == tgt_default)
+  if (PM && PM->TargetOffloadPolicy == tgt_default)
     handleDefaultTargetOffload();
----------------
JonChesterfield wrote:
> When do we call into this without initialising libomptarget? Seems a risk of claiming offload is disabled when it wouldn't be slightly later
Contingency if someone links against libomptarget without the associated registration code made by the linker wrapper.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131089/new/

https://reviews.llvm.org/D131089