[Openmp-commits] [PATCH] D131089: [Libomptarget] Explicitly init / deinit libomptarget from the user

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

I still think it's better for us to figure out if the lock here is necessary and document it explicitly.



================
Comment at: openmp/libomptarget/src/rtl.cpp:20
 #include <cassert>
+#include <condition_variable>
 #include <cstdlib>
----------------
leftover


================
Comment at: openmp/libomptarget/src/rtl.cpp:46
+void initLibomptarget() {
+  PluginMutex.lock();
+
----------------
lock guard will be better


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131089/new/

https://reviews.llvm.org/D131089