[Openmp-commits] [PATCH] D131000: [OpenMP][libomp] Detect if test compiler has omp.h

Jonathan Peyton via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Aug 2 11:53:47 PDT 2022


jlpeyton added a comment.

In D131000#3694188 <https://reviews.llvm.org/D131000#3694188>, @Meinersbur wrote:

> Rather than disabling the test, did you consider adding an `-I${CMAKE_CURRENT_BINARY_DIR}/runtime/src` (where `omp.h` resides) to the clang test flags? Even if there is an `omp.h` already on the system, libomp's header should be used instead since it may contain new symbols not yet present in the system's `omp.h`. It might even be `-isystem` to treat it like a system header.

The test doesn't become disabled. It uses the generated `omp.h` instead. This is the only test that attempts to use the system `omp.h` (or test compiler's `omp.h`). The original purpose was to test GCC compatibility of depobj which GCC defines differently than our `omp.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131000/new/

https://reviews.llvm.org/D131000



More information about the Openmp-commits mailing list