[Openmp-commits] [PATCH] D130927: [Libomptarget] Replace std::vector with llvm::SmallVector

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

LGTM with nits.



================
Comment at: openmp/libomptarget/include/device.h:24
 #include <set>
 #include <thread>
 
----------------
Generally it will be a good practice to include the header wherever it is used instead of indirect include.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:387
   // targetData* function using these new arrays.
-  std::vector<void *> MapperArgsBase(MapperComponents.Components.size());
-  std::vector<void *> MapperArgs(MapperComponents.Components.size());
-  std::vector<int64_t> MapperArgSizes(MapperComponents.Components.size());
-  std::vector<int64_t> MapperArgTypes(MapperComponents.Components.size());
-  std::vector<void *> MapperArgNames(MapperComponents.Components.size());
+  llvm::SmallVector<void *> MapperArgsBase(MapperComponents.Components.size());
+  llvm::SmallVector<void *> MapperArgs(MapperComponents.Components.size());
----------------
probably worth to `using llvm::SmallVector` in those `cpp` files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130927/new/

https://reviews.llvm.org/D130927