[Openmp-commits] [PATCH] D123891: [libomptarget] Make omp_target_is_present checks storage instead of zero length array.

[Joel E. Denny via Phabricator via Openmp-commits]

jdenny accepted this revision.
jdenny added a comment.
This revision is now accepted and ready to land.

LGTM based on your discussion so far with the language committee, but please give Ravi some time to comment.



================
Comment at: openmp/libomptarget/test/mapping/target_implicit_partial_map.c:19
+            omp_target_is_present(&arr[50], omp_get_default_device()));
+
+    // CHECK: should not present: 0
----------------
I suggest checking another boundary case too: `&arr[49]`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123891/new/

https://reviews.llvm.org/D123891