[Openmp-commits] [PATCH] D123888: [Clang][OpenMP] libompd: get libomp hwloc includedir by target_link_libraries

Bernhard Kaindl via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Apr 15 20:41:13 PDT 2022


bernhardkaindl added a comment.

https://reviews.llvm.org/D122667

In D123888#3455186 <https://reviews.llvm.org/D123888#3455186>, @ye-luo wrote:

> check_include_file is like writing an empty main with one include line and gets it compiled. So it doesn't pull any dependency.
> To test whether hwloc.h is a valid header file, you'd need to provide CMAKE_REQUIRED_INCLUDES pointing to hwloc.h.
> So it is needed.

Good, thanks for the explanation! LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123888/new/

https://reviews.llvm.org/D123888



More information about the Openmp-commits mailing list