[Openmp-commits] [PATCH] D123888: [Clang][OpenMP] libompd: get libomp hwloc includedir by target_link_libraries

[Ye Luo via Phabricator via Openmp-commits]

ye-luo accepted this revision.
ye-luo added a comment.
This revision is now accepted and ready to land.

One minor change requested. All the rest LGTM.



================
Comment at: openmp/runtime/cmake/config-ix.cmake:336
   set(CMAKE_REQUIRED_INCLUDES ${LIBOMP_HWLOC_INSTALL_DIR}/include)
+  find_path(LIBOMP_HWLOC_INCLUDE_DIR NAMES hwloc.h HINTS ${LIBOMP_HWLOC_INSTALL_DIR} PATH_SUFFIXES include)
   check_include_file(hwloc.h LIBOMP_HAVE_HWLOC_H)
----------------
Please remove line 335 and add after 336
 set(CMAKE_REQUIRED_INCLUDES ${LIBOMP_HWLOC_INCLUDE_DIR})


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123888/new/

https://reviews.llvm.org/D123888