[Openmp-commits] [PATCH] D122667: llvm14 patch: hwloc include directory for libompd

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Apr 15 18:51:13 PDT 2022


tianshilei1992 added a comment.

An add-up to this patch is, if both `ompd` and `omp` depend on `hwloc` (like including `hwloc` headers`), both should set `target_link_libraries`. The dependence should be:

  omp---->hwloc
           ^
  ompd-----|

The transitive dependence is bad practice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122667/new/

https://reviews.llvm.org/D122667



More information about the Openmp-commits mailing list