[Openmp-commits] [PATCH] D122667: llvm14 patch: hwloc include directory for libompd

[Bernhard Kaindl via Phabricator via Openmp-commits]

bernhardkaindl added a comment.

I just took a closer look to fix this and found this in `openmp/runtime/src/CMakeLists.txt`

  # Set the -I includes for all sources
  include_directories(
    ${CMAKE_CURRENT_BINARY_DIR}
    ${LIBOMP_SRC_DIR}
    ${LIBOMP_SRC_DIR}/i18n
    ${LIBOMP_INC_DIR}
    ${LIBOMP_SRC_DIR}/thirdparty/ittnotify
  )
  if(${LIBOMP_USE_HWLOC})
    include_directories(${LIBOMP_HWLOC_INSTALL_DIR}/include)
  endif()
  
  # Building with time profiling support requires LLVM directory includes.
  if(LIBOMP_PROFILING_SUPPORT)
    include_directories(
      ${LLVM_MAIN_INCLUDE_DIR}
      ${LLVM_INCLUDE_DIR}
    )
  endif()

To export ${LIBOMP_HWLOC_INSTALL_DIR}/include as an INTERFACE of the `omp` target, this needs to be modernized (Using include_directories() is very old cmake style) and applied to the omp target so it is exported as an interface with the omp target.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122667/new/

https://reviews.llvm.org/D122667