[Openmp-commits] [PATCH] D123444: [OpenMP][FIX] Simplify the entry deletion scheme

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Apr 13 10:02:44 PDT 2022


jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:907
+    // Remember we deleted the entry in case it shows up in the
+    // PostProcessingPtrs again.
+    DeletedEntries.insert(Info.Entry);
----------------
tianshilei1992 wrote:
> In what cases the same entry is in `PostProcessingPtrs` more than once?
We have a test case where this happens. I forgot which one. The entry shows up 3 times. The first and last time we do not want to delete it, the middle one is a deletion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123444/new/

https://reviews.llvm.org/D123444



More information about the Openmp-commits mailing list