[Openmp-commits] [PATCH] D113728: [libomptarget] [amdgpu] Foundation for OMPT target callback support

Dhruva Chakrabarti via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Apr 8 12:16:14 PDT 2022


dhruvachak marked an inline comment as done.
dhruvachak added inline comments.


================
Comment at: openmp/libomptarget/src/interface.cpp:130
+  }
 }
 
----------------
jdoerfert wrote:
> same as above, I'll stop pointing it out now.
Yes, I thought about the additional scope. But I was worried about future new code possibly messing up where exactly I want the RAII object dtor called.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113728/new/

https://reviews.llvm.org/D113728



More information about the Openmp-commits mailing list