[Openmp-commits] [PATCH] D113728: [libomptarget] [amdgpu] Foundation for OMPT target callback support

[Dhruva Chakrabarti via Phabricator via Openmp-commits]

dhruvachak marked 20 inline comments as done.
dhruvachak added a comment.

I addressed most of the feedback and updated this review. I will work on splitting up this patch into multiple pieces so that they can be reviewed more easily.



================
Comment at: openmp/libomptarget/include/ompt_device_callbacks.h:2
+//=== ompt_device_callbacks.h - Target independent OpenMP target RTL -- C++
+//-===//
+//
----------------
jdoerfert wrote:
> Nit: Style
clang-format makes this change and I left it alone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113728/new/

https://reviews.llvm.org/D113728