[Openmp-commits] [PATCH] D123359: [OpenMP][NFC] lit: Run barrier/reduction tests for each barrier implementation

[Misono Tomohiro via Phabricator via Openmp-commits]

t-msn created this revision.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
t-msn added a comment.
t-msn added reviewers: protze.joachim, tlwilmar, AndreyChurbanov.
t-msn added a project: OpenMP.
t-msn added a subscriber: openmp-commits.
t-msn published this revision for review.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

There are following reduction tests:

  $ LIT_OPTS="--show-pass --filter=reduction" ninja check-openmp
  ********************
  Passed Tests (15):
    libarcher :: reduction/parallel-reduction-nowait.c
    libarcher :: reduction/parallel-reduction.c
    libomp :: misc_bugs/teams-reduction.c
    libomp :: ompt/synchronization/reduction/empty_reduce.c
    libomp :: ompt/synchronization/reduction/tree_reduce.c
    libomp :: parallel/omp_parallel_reduction.c
    libomp :: tasking/kmp_task_reduction_nest.cpp
    libomp :: tasking/task_reduction1.c
    libomp :: tasking/task_reduction2.c
    libomp :: tasking/task_reduction3.c
    libomp :: tasking/task_reduction4.c
    libomp :: worksharing/for/omp_for_reduction.c
    libomp :: worksharing/for/omp_parallel_for_reduction.c
    libomp :: worksharing/sections/omp_parallel_sections_reduction.c
    libomp :: worksharing/sections/omp_sections_reduction.c

I thought these threes are enough to check each barrier's basic functionality:

  libomp :: ompt/synchronization/reduction/empty_reduce.c
  libomp :: ompt/synchronization/reduction/tree_reduce.c
  libomp :: parallel/omp_parallel_reduction.c

Let me know if this is wrong.  Dependency of D123193 <https://reviews.llvm.org/D123193> is to pass the tests.


There are several barrier algorithms in libomp and each barrier also impliments
its reduction scheme. Therefore basic barrier/reduction tests should be run
for each barrier.

Update following tests' lit to run the tests for each barrier currently supported
in libomp (linear, tree, hyper, hierachical and distribution):

barrier/omp_barrier.c
 ompt/synchronization/reduction/empty_reduce.c
 ompt/synchronization/reduction/tree_reduce.c
 parallel/omp_parallel_reduction.c

Depends on D123193 <https://reviews.llvm.org/D123193>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123359

Files:
  openmp/runtime/test/barrier/omp_barrier.c
  openmp/runtime/test/lit.cfg
  openmp/runtime/test/ompt/synchronization/reduction/empty_reduce.c
  openmp/runtime/test/ompt/synchronization/reduction/tree_reduce.c
  openmp/runtime/test/parallel/omp_parallel_reduction.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123359.421408.patch
Type: text/x-patch
Size: 8357 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20220408/bd000c65/attachment.bin>