[Openmp-commits] [PATCH] D122645: [OpenMP][NFC] lit: Allow setting default environment variables for test

[Misono Tomohiro via Phabricator via Openmp-commits]

t-msn added a comment.

> I checked the runtime tests and found that openmp/runtime/test/barrier/omp_barrier.c already triggers different combinations of barriers. Do the combinations cover all configurations you tried manually?

Not really.
There are currently 5 barriers in libomp: linear, tree, hyper(default), hier, dist.
With manually changing barriers with this patch, I don't see any problems with linear, tree and hyper while found some in hier and dist (incl. the problems addressed by other patches I submitted).

openmp/runtime/test/barrier/omp_barrier.c does not test linear and tree, so it may better to be added for completeness. 
(Also, omp_barrier.c checks barrier with KMP_BLOCKTIME=infinit. I tried changing barrier with this option and It seems KMP_BLOCKTIME=infinit makes problem in env/omp_wait_policy.c test regardless of barrier. I will try to see the reason)

> Regarding reductions, I think it would make sense to add similar run lines to openmp/runtime/test/worksharing/for/omp_for_reduction.c in order to cover different code paths in the runtime.

Ok, I will look that too.

Thanks for the review and comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122645/new/

https://reviews.llvm.org/D122645