[Openmp-commits] [PATCH] D123177: [libomptarget] Add device RTL to regression test dependencies.

[Kelvin Li via Phabricator via Openmp-commits]

kkwli0 added a comment.

In D123177#3434860 <https://reviews.llvm.org/D123177#3434860>, @Meinersbur wrote:

> In D123177#3433461 <https://reviews.llvm.org/D123177#3433461>, @kkwli0 wrote:
>
>> Not sure if it is related. If I do a clean `make check-openmp`, I see many failures due to missing `FileCheck` etc.
>>
>>   ...
>>   $ "build-llvm/./bin/FileCheck" "/llvm-project/openmp/runtime/test/ompt/parallel/nested_threadnum.c"
>>   # command stderr:
>>   'build-llvm/./bin/FileCheck': command not found
>>   error: command failed with exit status: 127
>
> I cannot reproduce, FileCheck is a correct dependency:
>
>   add_lit_testsuite(${target}
>     ${comment}
>     ${ARG_UNPARSED_ARGUMENTS}
>     EXCLUDE_FROM_CHECK_ALL
>     DEPENDS clang FileCheck not ${ARG_DEPENDS}
>     ARGS ${ARG_ARGS}
>   )
>
> However, for me in the tests FileCheck is resolved to an absolute path. Do you use a standalone build with incorrect (relative) paths to LLVM's build dir?

I don't think it is the path issue. The problem is that `FileCheck` is not built in `make check-openmp` for some reason.

  [kli at host build-llvm]$ pwd 
  /home/kli/wrk/f/build-llvm
  [kli at host build-llvm]$ ll bin/FileCheck
  /bin/ls: cannot access 'bin/FileCheck': No such file or directory
  [kli at host build-llvm]$ find . -type f -name FileCheck
  [kli at host build-llvm]$ 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123177/new/

https://reviews.llvm.org/D123177