[Openmp-commits] [PATCH] D122107: [OpenMP] Add support for ompt_callback_dispatch

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/runtime/src/ompt-internal.h:60
   int thread_num;
+  ompt_dispatch_chunk_t dispatch_chunk = {0, 0};
 } ompt_task_info_t;
----------------
This LoC creates tens of compilation warning. Please fix it.
```
In file included from /home/shiltian/Documents/vscode/llvm-project/openmp/runtime/src/kmp_affinity.cpp:13:
In file included from /home/shiltian/Documents/vscode/llvm-project/openmp/runtime/src/kmp.h:139:
/home/shiltian/Documents/vscode/llvm-project/openmp/runtime/src/ompt-internal.h:55:15: warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage]
typedef struct {
              ^
               ompt_task_info_t
/home/shiltian/Documents/vscode/llvm-project/openmp/runtime/src/ompt-internal.h:60:42: note: type is not C-compatible due to this default member initializer
  ompt_dispatch_chunk_t dispatch_chunk = {0, 0};
                                         ^~~~~~
/home/shiltian/Documents/vscode/llvm-project/openmp/runtime/src/ompt-internal.h:61:3: note: type is given name 'ompt_task_info_t' for linkage purposes by this typedef declaration
} ompt_task_info_t;
  ^
1 warning generated.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122107/new/

https://reviews.llvm.org/D122107