[Openmp-commits] [PATCH] D123177: [libomptarget] Add device RTL to regression test dependencies.

[Michael Kruse via Phabricator via Openmp-commits]

Meinersbur added a comment.

`LIBOMPTARGET_TESTED_PLUGINS` already exists and is already added to check-openmp and check-libomptarget dependencies in `openmp\libomptarget\test\CMakeLists.txt`:

    add_openmp_testsuite(check-libomptarget-${CURRENT_TARGET}
      "Running libomptarget tests"
      ${CMAKE_CURRENT_BINARY_DIR}/${CURRENT_TARGET}
      DEPENDS omptarget omp ${LIBOMPTARGET_TESTED_PLUGINS}
      ARGS ${LIBOMPTARGET_LIT_ARG_LIST})
  [... ]
  add_openmp_testsuite(check-libomptarget
    "Running libomptarget tests"
    ${LIBOMPTARGET_LIT_TESTSUITES}
    EXCLUDE_FROM_CHECK_ALL
    DEPENDS omptarget omp ${LIBOMPTARGET_TESTED_PLUGINS}
    ARGS ${LIBOMPTARGET_LIT_ARG_LIST})

Elements are only added by plugins that use the `build_generic_elf64` macro, so I guess the dependencies have been accidentally dropped at some point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123177/new/

https://reviews.llvm.org/D123177