[Openmp-commits] [PATCH] D123193: [OpenMP] libomp: Add missing ompt callbacks in hier barrier reduction

[Misono Tomohiro via Phabricator via Openmp-commits]

t-msn added a comment.

> Can you add extra run lines to openmp/runtime/test/ompt/synchronization/reduction/*_reduce.c in order to trigger the different barrier implementations?

Ok.

This is a bit out of topic,  but currently tree_reduce tests fails on dist barrier but I think this is a test problem.
As spec says:

> If a task participates in multiple reductions, each reduction may be bracketed by its own pair of reduction-begin/reduction-end events or multiple reductions may be bracketed by a single pair of events.

I read this as reduction-begin & end event may occur 1 to ~ number of reductions. Dist barrier put 1 ompt event for reductions surrounding for-loop while other barriers call ompt event in each reduction
and therefore  this results in mismatch in the number of called events. I don't know lit's CHECK pattern matching can handle to check if lines appear 1 ~ X times, let me think. (maybe just easier to fix dist barrier handling anyway)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123193/new/

https://reviews.llvm.org/D123193