[Openmp-commits] [PATCH] D122107: [OpenMP] Add support for ompt_callback_dispatch

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim accepted this revision.
protze.joachim added a comment.

Thanks for working on this!

Just one comment inline.



================
Comment at: openmp/runtime/test/ompt/callback.h:792-802
         case ompt_work_loop:
+        case ompt_work_loop_static:
+        case ompt_work_loop_dynamic:
+        case ompt_work_loop_guided:
+        case ompt_work_loop_other:
           printf("%" PRIu64 ":" _TOOL_PREFIX
                  " ompt_event_loop_begin: parallel_id=%" PRIu64
----------------
Can you probably add a TODO, that we should add a new attribute here: `", schedule=%s" ... ompt_schedule_values[wstype]`?

This can be added with the specialization change of `ompt_work_loop`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122107/new/

https://reviews.llvm.org/D122107