[Openmp-commits] [PATCH] D110679: [libomptarget] [amdgpu] After a kernel dispatch packet is published, its contents must not be accessed.

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

Change looks non-functional to me. Lifetime of signal s increased, accesses to signal and kernarg memory are made through variables instead of lifting back out of the queue. So that's fine.

What's the problem with the current code? SWDEV-275232 looks like an internal link, and I don't know of anything in the HSA spec to say the contents of the queue buffer can't be touched after the signal store + atomic write to the top combination. Is this requirement documented somewhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110679/new/

https://reviews.llvm.org/D110679