[Openmp-commits] [PATCH] D110556: [openmp] Add addrspacecast to getOrCreateIdent

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

We should put it in the right AS by construction. That matches the stack case and is the right thing to do. Casting things after the fact is a necessary evil but not a solution.
I don't know how clang decides they go into AS(1) but we should do the same. Some datalayout or target hook should exist to tell us that. Instead of `OpenMPIRBuilder::Ident` we
would cast that type first into the AS we need and then create the global. The rest should fall in place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110556/new/

https://reviews.llvm.org/D110556