[Openmp-commits] [openmp] 726a34f - [libomptarget][amdgpu] Replace dead exit call with returning error

[Jon Chesterfield via Openmp-commits]

Author: Jon Chesterfield
Date: 2021-09-27T09:43:37+01:00
New Revision: 726a34f06310d466f7fdc6e85a60103dec399086

URL: https://github.com/llvm/llvm-project/commit/726a34f06310d466f7fdc6e85a60103dec399086
DIFF: https://github.com/llvm/llvm-project/commit/726a34f06310d466f7fdc6e85a60103dec399086.diff

LOG: [libomptarget][amdgpu] Replace dead exit call with returning error

Added: 
    

Modified: 
    openmp/libomptarget/plugins/amdgpu/impl/system.cpp

Removed: 
    


################################################################################
diff  --git a/openmp/libomptarget/plugins/amdgpu/impl/system.cpp b/openmp/libomptarget/plugins/amdgpu/impl/system.cpp
index 8682fede569d..da2ab765e8ab 100644
--- a/openmp/libomptarget/plugins/amdgpu/impl/system.cpp
+++ b/openmp/libomptarget/plugins/amdgpu/impl/system.cpp
@@ -592,12 +592,8 @@ populate_InfoTables(hsa_executable_symbol_t symbol,
     // because the non-ROCr custom code object parsing is called before
     // iterating over the code object symbols using ROCr
     if (KernelInfoTable.find(kernelName) == KernelInfoTable.end()) {
-      if (HSA_STATUS_ERROR_INVALID_CODE_OBJECT != HSA_STATUS_SUCCESS) {
-        printf("[%s:%d] %s failed: %s\n", __FILE__, __LINE__,
-               "Finding the entry kernel info table",
-               get_error_string(HSA_STATUS_ERROR_INVALID_CODE_OBJECT));
-        exit(1);
-      }
+      DP("amdgpu internal consistency error\n");
+      return HSA_STATUS_ERROR;
     }
     // found, so assign and update
     info = KernelInfoTable[kernelName];