[Openmp-commits] [PATCH] D110251: [OpenMP][CMake] Use in-project clang as CUDA->IR compiler for new DeviceRTL.

Sat Sep 25 22:36:02 PDT 2021

Meinersbur added inline comments.

================
Comment at: openmp/libomptarget/DeviceRTL/CMakeLists.txt:41
   set(cuda_compiler ${LIBOMPTARGET_NVPTX_CUDA_COMPILER})
+elseif (LLVM_TOOL_CLANG_BUILD AND NOT CMAKE_CROSSCOMPILING)
+  # Compile the deviceRTL with the clang that is built in the project.
----------------
tianshilei1992 wrote:
> `LLVM_TOOL_CLANG_BUILD` seems already obsolete. I searched the whole LLVM project but didn't find where it is defined. The only two places it is still being used is in polly and libomptarget.
It is defined here: https://github.com/llvm/llvm-project/blob/e21b0ba8c9378bca01d2311be4e1b6ccd3397bc4/llvm/CMakeLists.txt#L141

It is deprecated to be set by the user, as the comment before is explaining. It is still an integral part of the entire external project mechanism: https://github.com/llvm/llvm-project/blob/e21b0ba8c9378bca01d2311be4e1b6ccd3397bc4/llvm/cmake/modules/AddLLVM.cmake#L1355

There are not many literal `LLVM_TOOL_CLANG_BUILD` strings because its implementation is mostly generic for all tools, not just clang. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110251/new/

https://reviews.llvm.org/D110251