[Openmp-commits] [PATCH] D110251: [OpenMP][CMake] Use in-project clang as CUDA->IR compiler for new DeviceRTL.

[Michael Kruse via Phabricator via Openmp-commits]

Meinersbur added a comment.

In D110251#3015450 <https://reviews.llvm.org/D110251#3015450>, @tianshilei1992 wrote:

> Generally looks better than previous patch. Thanks for that. This patch assumes those targets must be there in runtime build, which might not be the case.

I think it could be better if we first check if those targets are there.

The clang target does not exist at this point since the CMake script for openmp is processed before clang.

> If not, raise an error directly, saying runtime build requires `clang`, etc.

The error already exists: "Not building deviceRTL: clang not found", unless a CUDA->IR compiler is explicitly specified with LIBOMPTARGET_NVPTX_CUDA_COMPILER .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110251/new/

https://reviews.llvm.org/D110251