[Openmp-commits] [PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

In D102107#3014743 <https://reviews.llvm.org/D102107#3014743>, @pdhaliwal wrote:

> I got this after changing __kmpc_impl_malloc to return 0xdeadbeef. So, this confirms that missing malloc implementation is the root cause.
>
>> Memory access fault by GPU node-4 (Agent handle: 0x1bc5000) on address 0xdeadb000. Reason: Page not present or supervisor privilege.

Nice! In that case I think the way to go is to audit the (probably few) places where kmpc_impl_malloc are called and add a check for whether the return value is 0. With that in place we can reland this and get more graceful failure (at a guess we should fall back to the host when gpu memory is exhausted? or maybe just print a 'out of gpu heap memory' style message and abort, don't know).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102107/new/

https://reviews.llvm.org/D102107