[Openmp-commits] [PATCH] D110202: [OpenMP] Add function tracing debugging to device RTL

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, one  nit.



================
Comment at: openmp/libomptarget/DeviceRTL/src/Debug.cpp:53
+/// Current indentation level for the function trace. Only accessed by thread 0.
+uint32_t Level = 0;
+} // namespace
----------------
This needs to be in shared memory. `static` works fine, no namespace needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110202/new/

https://reviews.llvm.org/D110202