[Openmp-commits] [PATCH] D110006: [OpenMP] Add support for dynamic shared memory in new RTL

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

LGTM with some nits.



================
Comment at: openmp/libomptarget/DeviceRTL/include/Configuration.h:35
+/// Return the amount of dynamic shared memory that was allocated at launch.
+uint64_t getDynamicMemSize();
+
----------------
`getDynamicMemorySize`? I just feel since other words like "dynamic" or "size" we all use the full version, we could also use "memory" here?


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:547
     }
+    if (const char *EnvStr = getenv("LIBOMPTARGET_SHARED_MEMORY")) {
+      // LIBOMPTARGET_SHARED_MEMORY has been set
----------------
`LIBOMPTARGET_SHARED_MEMORY_SIZE`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110006/new/

https://reviews.llvm.org/D110006