[Openmp-commits] [PATCH] D110004: [OpenMP] Add additional fields to device environment

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Can you also double check that this works actually. print the device id and number of devices? Assuming it does, LG



================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:906
+          0, static_cast<uint32_t>(NumberOfDevices),
+          static_cast<uint32_t>(DeviceId)};
 
----------------
The slight problem is that DeviceId here is not the OpenMP device ID, IIRC.
The plugins have a local view and we'd need the "global" view. 
But for now this is good enough as we don't really deal with mutli-plugin
situations yet. Add a TODO though.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110004/new/

https://reviews.llvm.org/D110004