[Openmp-commits] [PATCH] D109875: [AMDGPU][Libomptarget] Refactor device/host memory pools setup

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

We've lost some error checking in the refactor but otherwise it looks like an improvement



================
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:636
 
     return HSA_STATUS_SUCCESS;
   }
----------------
This is going to return success if it finds a pool for either kernarg or fine grain. I think we should only be claiming success if we've found (at least?) one for each. We could handle the control flow for that by initialising both pools to {0} and checking neither is {0} before returning, or by keeping track of whether both have been initialized


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109875/new/

https://reviews.llvm.org/D109875