[Openmp-commits] [PATCH] D109468: [OpenMP][FIX] Be more deliberate about invalidating the AAKernelInfo state

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3012
     if (!changeToSPMDMode(A))
-      buildCustomStateMachine(A);
+      return buildCustomStateMachine(A);
 
----------------
jdoerfert wrote:
> tianshilei1992 wrote:
> > Don't you expect anything else between in the future?
> I do not understand the question. Generally, if this is not proper in the future we can change it.
> For now, we should return the right thing, that is unchanged if we did not do anything.
If we don't expect anything (any other manipulation) in the future between line 3006 and 3008, the change here is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109468/new/

https://reviews.llvm.org/D109468