[Openmp-commits] [PATCH] D106674: Runtime for Interop directive

[Ravi Narayanaswamy via Phabricator via Openmp-commits]

RaviNarayanaswamy added inline comments.


================
Comment at: openmp/libomptarget/src/interop.cpp:198-201
+  if (interop_type == kmp_interop_type_tasksync) {
+    __kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias,
+                         noalias_dep_list);
+  }
----------------
jdoerfert wrote:
> RaviNarayanaswamy wrote:
> > Interop object does not wait for any task from libomp.  
> > Init just initializes the interop object.
> > The initialization of interop object should  be done by the plugin as only the plugin knows what properties are supported
> > Interop object does not wait for any task from libomp. 
> 
> I don't know why you think we would not wait for libomp tasks. If we have dependences we need to wait for them.
> 
> > The initialization of interop object should be done by the plugin as only the plugin knows what properties are supported.
> 
> It is, below. This is the generic part that then redirects to the plugin.
Libomp would have not invoked the task which calls this routine if there are dependences.   They must be executed before the task containing  the interop creation is scheduled.

The interop_type should be passed to plugin and let it initialize the common for all interop-types and then add based on the interop_type 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106674/new/

https://reviews.llvm.org/D106674