[Openmp-commits] [PATCH] D109511: [libomptarget][amdgpu] Clean up destruction of hsa queue, signals
Jon Chesterfield via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Thu Sep 9 08:34:30 PDT 2021
JonChesterfield planned changes to this revision.
JonChesterfield added a comment.
D109512 <https://reviews.llvm.org/D109512> rearranges rtl.cpp so that hsa is reliably constructed before other member variables in the big global object. If we land that, this signal pool can be refactored to free the signals in the destructor again. Still some care needed to ensure it doesn't try to create any without checking hsa is available, i.e. don't prepopulate the pool in the constructor, but at least cleanup can be implicit.
Likewise could put queue in a unique_ptr or similar to reliably cleanup.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the Openmp-commits