[Openmp-commits] [PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

Thu Sep 9 06:07:27 PDT 2021

tianshilei1992 added inline comments.

================
Comment at: clang/test/Driver/openmp-offload-gpu.c:153
-/// bitcode library and add it to the LIBRARY_PATH.
-// RUN:   env LIBRARY_PATH=%S/Inputs/libomptarget %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda \
-// RUN:   -Xopenmp-target -march=sm_35 --cuda-path=%S/Inputs/CUDA_102/usr/local/cuda \
----------------
JonChesterfield wrote:
> tianshilei1992 wrote:
> > Seems like we don't have a test for the fallback version now?
> Yes, indeed. That seemed reasonable to me, but can add some more stub files and check they can be found. I'll do that today - would really like this to go in soon enough that it can make it to the llvm-13 branch.
Yeah, please do. If we provide one feature, it’s better to be tested.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109061/new/

https://reviews.llvm.org/D109061