[Openmp-commits] [PATCH] D109017: [OpenMP][libomptarget] Add event query plugin API

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added inline comments.


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:162
 
+int queryEvent(void *EventPtr, TargetEventStatusTy *EventStatus) {
+  CUevent Event = reinterpret_cast<CUevent>(EventPtr);
----------------
ye-luo wrote:
> tianshilei1992 wrote:
> > IMO, it's better to extend the return value, aka `OFFLOAD_SUCCESS`, instead of using this method. Currently we have two status, `0`, and `~0`. We can add plenty of status.
> Add D109277 to warmup and detect potential issues.
Change macro to enum takes a bit longer. So just keep using macro for the moment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109017/new/

https://reviews.llvm.org/D109017