[Openmp-commits] [PATCH] D109277: [OpenMP][libomptarget] Change internal return status to enum type

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

LGTM. One nit.



================
Comment at: openmp/libomptarget/include/omptarget.h:29
+/// return error status
+enum __tgt_error : int32_t {
+  OFFLOAD_SUCCESS = 0,
----------------
What about `enum tgt_return_value : uint32_t`, and set `OFFLOAD_FAIL = ~0U`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109277/new/

https://reviews.llvm.org/D109277