[Openmp-commits] [PATCH] D109276: [OpenMP][libomptarget] Change device vector elements to unique_ptr type

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added inline comments.


================
Comment at: openmp/libomptarget/src/device.h:279
-  // provide a copy constructor and an assignment operator explicitly.
-  DeviceTy(const DeviceTy &D);
-
----------------
tianshilei1992 wrote:
> Mark them as `delete` if you expect it should not be copied at all.
Added. It makes the non-copyable nature explicitly expressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109276/new/

https://reviews.llvm.org/D109276