[Openmp-commits] [PATCH] D109017: [OpenMP][libomptarget] Add event query plugin API

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Sep 3 10:57:03 PDT 2021


tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:162
 
+int queryEvent(void *EventPtr, TargetEventStatusTy *EventStatus) {
+  CUevent Event = reinterpret_cast<CUevent>(EventPtr);
----------------
IMO, it's better to extend the return value, aka `OFFLOAD_SUCCESS`, instead of using this method. Currently we have two status, `0`, and `~0`. We can add plenty of status.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109017/new/

https://reviews.llvm.org/D109017



More information about the Openmp-commits mailing list