[Openmp-commits] [PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

New runtime failing CI suggests it may take some iteration to land, so reworked this to make sense with or without it.

Doesn't make much difference to nvptx - printf still ultimately resolves to the same vprintf function as before - but a lot of tests that were previously disabled for amdgpu because references to printf were a linker error will now build and run, some of them successfully.



================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.hip:189
+int32_t __llvm_omp_vprintf(const char *Format, void *Arguments, uint32_t) {
+  return 1;
+}
----------------
this should be -1, for 'error'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112680/new/

https://reviews.llvm.org/D112680