[Openmp-commits] [PATCH] D112544: [Attributor][FIX] Use right address space to avoid assertion

[Matt Arsenault via Phabricator via Openmp-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:1249-1250
         // Check if the PHI operand is not dependent on the PHI itself.
-        APInt Offset(DL.getIndexTypeSizeInBits(AssociatedValue.getType()), 0);
+        // TODO: This is not great as we look at the pointer type. However, it
+        // is unclear where the Offset size comes from with typeless pointers.
+        APInt Offset(
----------------
This is only using the type to get the address space, there's nothing bad going on here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112544/new/

https://reviews.llvm.org/D112544