[Openmp-commits] [PATCH] D110699: [OpenMP][OMPT] thread_num determination during execution of nested serialized parallel regions

Vladimir Inđić via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Oct 25 05:11:15 PDT 2021

vladaindjic marked an inline comment as done.
vladaindjic added a comment.

@protze.joachim Thank you for the revision. Could you please land this patch for me?

Comment at: openmp/runtime/test/ompt/parallel/nested_lwt_thread_num.c:87
+  // thread_num is the most important
+  // CHECK: {{^}}[[WORKER_ID]]: ancestor_level=0 id=1
+  // CHECK-SAME: parallel_id=[[PARALLEL_ID_1]] task_id=[[TASK_ID_2]]
protze.joachim wrote:
> There is no guaranteed ordering of implicit task begin on primary thread and the output on the worker thread. 
> Adding a barrier at the beginning of the parallel region should make the test more robust.
@protze.joachim Thanks for the comment. As you proposed, the explicit barrier has been added at the beginning of the parallel region. Does the test case look complete now?

  rG LLVM Github Monorepo



More information about the Openmp-commits mailing list